Skip to content

Conversation

@urkle
Copy link
Contributor

@urkle urkle commented Jan 6, 2026

Fixes #1014


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 6, 2026 14:18
@mrgrain mrgrain changed the title feat: Add in support for resourceModel to the CC API Context Provider feat: support resourceModel in the CCAPI Context Provider Jan 12, 2026
@github-actions github-actions bot added the effort/medium 1-3 days of effort label Jan 12, 2026
@mrgrain mrgrain self-requested a review January 12, 2026 13:16
@mrgrain
Copy link
Contributor

mrgrain commented Jan 12, 2026

@urkle there are some type issues.

auto-merge was automatically disabled January 12, 2026 13:52

Head branch was pushed to by a user without write access

@urkle urkle force-pushed the feat/cc-api-resourceModel branch from d30b8c2 to 5859689 Compare January 12, 2026 13:52
@urkle urkle force-pushed the feat/cc-api-resourceModel branch from 5859689 to 80979fd Compare January 12, 2026 14:12
@urkle urkle temporarily deployed to integ-approval January 12, 2026 14:12 — with GitHub Actions Inactive
@urkle
Copy link
Contributor Author

urkle commented Jan 12, 2026

@mrgrain I rebased and fixed the type issue. (and ran tests locally again to ensure)

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.72%. Comparing base (29249ac) to head (80979fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files          72       72           
  Lines       10087    10087           
  Branches     1330     1330           
=======================================
  Hits         8849     8849           
  Misses       1213     1213           
  Partials       25       25           
Flag Coverage Δ
suite.unit 87.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain added this pull request to the merge queue Jan 12, 2026
Merged via the queue into aws:main with commit 2e92d71 Jan 12, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@aws_cdk/toolkit-lib: CcApiContextProviderPlugin needs support for resourceModel parameter

3 participants